Make -Ztrack-diagnostics emit like a note #143286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @WaffleLapkin. Use |
rustbot
added
S-waiting-on-review
|
It's now emitted as a note into the json output as well, right? Could you then migrate tests using
|
Muscraft
force-pushed
the
track-diagnostics-note
branch
from
b528aba to
dc4877b
Compare
No, I only made it so that it gets rendered like a
Since this isn't changing the json, would you still like me to do this? |
This comment has been minimized.
This comment has been minimized.
Compiletest is working on the json output, so |
Muscraft
force-pushed
the
track-diagnostics-note
branch
from
dc4877b to
e47cd86
Compare
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Muscraft
force-pushed
the
track-diagnostics-note
branch
from
e47cd86 to
6d3ffe1
Compare
I don't know how I would add it to the JSON output, but if I need to, I'll see what I can figure out. |
rustbot
added
S-waiting-on-author
Muscraft
force-pushed
the
track-diagnostics-note
branch
2 times, most recently
from
64745dc to
3a82c35
Compare
This comment has been minimized.
This comment has been minimized.
Muscraft
force-pushed
the
track-diagnostics-note
branch
from
3a82c35 to
f361b92
Compare
Muscraft
force-pushed
the
track-diagnostics-note
branch
from
f361b92 to
6bef238
Compare
|
@rustbot label -S-waiting-on-author +S-waiting-on-review |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 4, 2025
Rollup of 7 pull requests Successful merges: - #140643 (Refactor StableMIR) - #143286 (Make -Ztrack-diagnostics emit like a note) - #143308 (Remove `PointerLike` trait) - #143387 (Make __rust_alloc_error_handler_should_panic a function) - #143400 (Port `#[rustc_pass_by_value]` to the new attribute system) - #143417 (bump termize dep) - #143420 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 4, 2025
Rollup merge of #143286 - Muscraft:track-diagnostics-note, r=WaffleLapkin Make -Ztrack-diagnostics emit like a note [#t-compiler/diagnostics > Rendering -Ztrack-diagnostics like a note](https://rust-lang.zulipchat.com/#narrow/channel/147480-t-compiler.2Fdiagnostics/topic/Rendering.20-Ztrack-diagnostics.20like.20a.20note/with/526608647) As discussed on the Zulip thread above, I want to make `-Ztrack-diagnostics` emit like a `note`. This is because I find its current output jarring, and the fact that it gets rendered completely left-aligned, [even in the middle of a snippet](https://github.com/rust-lang/rust/blob/86e05cd300fac9e83e812c4d46582b48db780d8f/tests/ui/track-diagnostics/track6.stderr), seems like something that should be changed. Turning it into a `note` seems like the best choice, as it would align it with the rest of the output, and `note` is already used for somewhat similar things, like seeing why a lint was fired. --- Note: turning `-Ztrack-diagnostics` into a `note` will also make `annotate-snippets` API a bit cleaner
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jul 7, 2025
Rollup of 7 pull requests Successful merges: - rust-lang/rust#140643 (Refactor StableMIR) - rust-lang/rust#143286 (Make -Ztrack-diagnostics emit like a note) - rust-lang/rust#143308 (Remove `PointerLike` trait) - rust-lang/rust#143387 (Make __rust_alloc_error_handler_should_panic a function) - rust-lang/rust#143400 (Port `#[rustc_pass_by_value]` to the new attribute system) - rust-lang/rust#143417 (bump termize dep) - rust-lang/rust#143420 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 10, 2025
…=WaffleLapkin Make -Ztrack-diagnostics emit like a note [#t-compiler/diagnostics > Rendering -Ztrack-diagnostics like a note](https://rust-lang.zulipchat.com/#narrow/channel/147480-t-compiler.2Fdiagnostics/topic/Rendering.20-Ztrack-diagnostics.20like.20a.20note/with/526608647) As discussed on the Zulip thread above, I want to make `-Ztrack-diagnostics` emit like a `note`. This is because I find its current output jarring, and the fact that it gets rendered completely left-aligned, [even in the middle of a snippet](https://github.com/rust-lang/rust/blob/86e05cd300fac9e83e812c4d46582b48db780d8f/tests/ui/track-diagnostics/track6.stderr), seems like something that should be changed. Turning it into a `note` seems like the best choice, as it would align it with the rest of the output, and `note` is already used for somewhat similar things, like seeing why a lint was fired. --- Note: turning `-Ztrack-diagnostics` into a `note` will also make `annotate-snippets` API a bit cleaner
Muscraft
pushed a commit
to Muscraft/rust
that referenced
this pull request
Jul 21, 2025
…=WaffleLapkin Make -Ztrack-diagnostics emit like a note [#t-compiler/diagnostics > Rendering -Ztrack-diagnostics like a note](https://rust-lang.zulipchat.com/#narrow/channel/147480-t-compiler.2Fdiagnostics/topic/Rendering.20-Ztrack-diagnostics.20like.20a.20note/with/526608647) As discussed on the Zulip thread above, I want to make `-Ztrack-diagnostics` emit like a `note`. This is because I find its current output jarring, and the fact that it gets rendered completely left-aligned, [even in the middle of a snippet](https://github.com/rust-lang/rust/blob/86e05cd300fac9e83e812c4d46582b48db780d8f/tests/ui/track-diagnostics/track6.stderr), seems like something that should be changed. Turning it into a `note` seems like the best choice, as it would align it with the rest of the output, and `note` is already used for somewhat similar things, like seeing why a lint was fired. --- Note: turning `-Ztrack-diagnostics` into a `note` will also make `annotate-snippets` API a bit cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#t-compiler/diagnostics > Rendering -Ztrack-diagnostics like a note
As discussed on the Zulip thread above, I want to make
-Ztrack-diagnosticsemit like anote. This is because I find its current output jarring, and the fact that it gets rendered completely left-aligned, even in the middle of a snippet, seems like something that should be changed. Turning it into anoteseems like the best choice, as it would align it with the rest of the output, andnoteis already used for somewhat similar things, like seeing why a lint was fired.Note: turning
-Ztrack-diagnosticsinto anotewill also makeannotate-snippetsAPI a bit cleaner